Skip to content

Commit

Permalink
Fix order of judgings on submission page.
Browse files Browse the repository at this point in the history
Found while looking at DOMjudge#2191, see this comment:
DOMjudge#2191 (comment)

Previously, we treated the start time as higher priority indicator than
the judgingId for sorting the rows. For submissions that are queued we
don't have a starttime yet, so they show up first.

Now, the order is purely by judgingid. For one specific submission,
the starttime of judgings should always be in order of their judgingid
so this change should be a no-op otherwise.
  • Loading branch information
meisterT committed Nov 23, 2023
1 parent 5547b1a commit 7112ab3
Showing 1 changed file with 1 addition and 2 deletions.
3 changes: 1 addition & 2 deletions webapp/src/Controller/Jury/SubmissionController.php
Original file line number Diff line number Diff line change
Expand Up @@ -217,8 +217,7 @@ public function viewAction(
->setParameter('contest', $submission->getContest())
->setParameter('submission', $submission)
->groupBy('j.judgingid')
->orderBy('j.starttime')
->addOrderBy('j.judgingid')
->orderBy('j.judgingid')
->getQuery()
->getResult();

Expand Down

0 comments on commit 7112ab3

Please sign in to comment.