-
Notifications
You must be signed in to change notification settings - Fork 0
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Cv2 3833 compute and save sscd embeddings for images #47
base: master
Are you sure you want to change the base?
Cv2 3833 compute and save sscd embeddings for images #47
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Pretty cool to see a new model deployed! I think it would be really helpful to have a basic test for this? Like 3 images, two are expected to have embeddings match and one that doesn't?
…rom sscd-copy-detection installation
…Model().compute_pdq(io.BytesIO(image_content))` in test_image.py
* Create GenericImageModel and have pdq and sscd inherit form it * Move model loading for sscd to __init__ * Update requirements.txt for sscd
class Model(GenericImageModel): | ||
def __init__(self): | ||
super().__init__() | ||
#FIXME: Load from a Meedan S3 bucket |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
This is still to do
Currently failing due to a Docker issue
It's building and working fine locally because this image is cached. Before we merge this, we need to write tests for SSCD. Can you please look at |
…_pdq import Model` in `test_image_pdq.py`
…f github.com:meedan/presto into CV2-3833-Compute-and-save-SSCD-embeddings-for-images
…sizing of the image
@DGaffney This was not merged before the refactor. Can you please review? We'd like to get this added to Presto after the next deploy. The conflicts with image and test_image should be minor. Those files are just renamed to have |
I can take a look this week. |
@ahmednasserswe please provide a full description here including how this was tested. Note that we still need to add unit tests for SSCD.
Three requests I've used to test locally: