Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Adding ports to docker-compose.yml #46

Closed
wants to merge 1 commit into from
Closed

Adding ports to docker-compose.yml #46

wants to merge 1 commit into from

Conversation

ahmednasserswe
Copy link
Contributor

adding

    ports:
      - "${PRESTO_PORT}:${PRESTO_PORT}"

to docker-compose.yml to fix missing ports error

skyemeedan
skyemeedan approved these changes Oct 18, 2023
View reviewed changes
Copy link
Contributor

@skyemeedan skyemeedan left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I see there is a corresponding PRESTO_PORT=8000 in the env file

@computermacgyver
Copy link
Collaborator

No longer needed.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@skyemeedan skyemeedan skyemeedan approved these changes

@DGaffney DGaffney Awaiting requested review from DGaffney DGaffney is a code owner

@computermacgyver computermacgyver Awaiting requested review from computermacgyver computermacgyver is a code owner

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@ahmednasserswe @computermacgyver @skyemeedan