Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

CV2-5639 use direct poll waiter in SQS #135

Merged
merged 1 commit into from
Dec 3, 2024
Merged

Conversation

DGaffney
Copy link
Collaborator

@DGaffney DGaffney commented Dec 2, 2024

Description

Remove external time sleep and opt for SQS's canonical waiter

Reference: CV2-5639

How has this been tested?

Not tested locally

Are there any external dependencies?

None

Have you considered secure coding practices when writing this code?

None

Copy link
Collaborator

@computermacgyver computermacgyver left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Approved pending tests passing

@DGaffney DGaffney merged commit 8270381 into master Dec 3, 2024
2 checks passed
@DGaffney DGaffney deleted the cv2-5639-sleepy-time-2 branch December 3, 2024 00:05
Copy link

sentry-io bot commented Dec 3, 2024

Suspect Issues

This pull request was deployed and Sentry observed the following issues:

  • ‼️ ParamValidationError: Parameter validation failed: lib.queue.queue in receive_messages View Issue

Did you find this useful? React with a 👍 or 👎

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants