CV2-5589 More support for queuing under threaded environments #121
Conversation
DGaffney
requested review from
computermacgyver and
skyemeedan
as code owners
lib/queue/queue.py
Outdated
| attributes = {} | ||
| if queue_name.endswith('.fifo'): | ||
| attributes['FifoQueue'] = 'true' | ||
| attributes['ContentBasedDeduplication'] = 'true' |
There was a problem hiding this comment.
Is attributes['ContentBasedDeduplication'] related to the queue ending in .fifo or is it something we want all the time?
There was a problem hiding this comment.
its a fifo thing - and I realized I copypasta'd here twice so removing one of these!
There was a problem hiding this comment.
Right; the deduplication is an aspect of how FIFO queues work (where you avoid processing the same message more than once). I don't think we'll ever have a scenario with FIFO, but without deduplication, but it doesn't seem unreasonable to separate these aspects.
| """ | ||
| Send a message to a specific queue. | ||
| """ | ||
| queue = self.get_or_create_queue(queue_name) |
There was a problem hiding this comment.
Do we really need to look up the queue each time we send a message? I would have hoped we could store a reference after looking it up once
There was a problem hiding this comment.
My understanding is that if we do store it we introduce a bunch of state which causes our problem in the first place
There was a problem hiding this comment.
The first call it will create the resource object, but then it will return a thread local reference on every subsequent request (within that thread). I think this is necessary due to the context switching that could happen otherwise...
Suspect IssuesThis pull request was deployed and Sentry observed the following issues:
Did you find this useful? React with a 👍 or 👎 |
Description
Responding to more issues where we fail to pickup queues under threaded environments. More work to make it threadsafe
Reference: CV2-5589
How has this been tested?
Tested locally and continues to work!
Are there any external dependencies?
No change
Have you considered secure coding practices when writing this code?
No Change