Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

CV2-5589 add explicit timeout #119

Merged
merged 2 commits into from
Nov 14, 2024
Merged

CV2-5589 add explicit timeout #119

merged 2 commits into from
Nov 14, 2024

Conversation

DGaffney
Copy link
Collaborator

Description

Adds 30s timeout and some logs to help diagnose long running callbacks

Reference: CV2-5589

How has this been tested?

Not tested locally

Are there any external dependencies?

Nope!

Have you considered secure coding practices when writing this code?

None

@DGaffney DGaffney requested a review from sonoransun November 14, 2024 14:15
Copy link
Contributor

@sonoransun sonoransun left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good! Will be interesting to see the tests this time round.

@DGaffney DGaffney merged commit 6e3d1db into master Nov 14, 2024
2 checks passed
@DGaffney DGaffney deleted the cv2-5589-timeouts-and-logs branch November 14, 2024 15:18
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants