Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

adding auto langdetect and cleaning up keywords extracted by yake #107

Merged
Merged
Show file tree
Hide file tree
Changes from 5 commits
Commits
File filter

Filter by extension

Filter by extension


Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
37 changes: 35 additions & 2 deletions lib/model/yake_keywords.py
Original file line number Diff line number Diff line change
Expand Up @@ -7,8 +7,25 @@
from lib import schemas

import yake
import cld3

class Model(Model):

def keep_largest_overlapped_keywords(self, keywords):
ahmednasserswe marked this conversation as resolved.
Show resolved Hide resolved
cleaned_keywords = []
for i in range(len(keywords)):
keep_keyword = True
for j in range(len(keywords)):
current_keyword = keywords[i][0]
other_keyword = keywords[j][0]
if len(other_keyword) > len(current_keyword):
if other_keyword.find(current_keyword + " ") >= 0 or other_keyword.find(" " + current_keyword) >= 0:
keep_keyword = False
break
if keep_keyword:
cleaned_keywords.append(keywords[i])
return cleaned_keywords

def run_yake(self, text: str,
language: str,
max_ngram_size: int,
Expand All @@ -26,15 +43,31 @@ def run_yake(self, text: str,
:param num_of_keywords: int
:returns: str
"""
### if language is set to "auto", auto-detect it.
ahmednasserswe marked this conversation as resolved.
Show resolved Hide resolved
if language == 'auto':
language = cld3.get_language(text).language
ahmednasserswe marked this conversation as resolved.
Show resolved Hide resolved
### replace special characters
replacement = {"`": "'",
"‘": "'",
"’": "'",
"“": "\"",
"”": "\""}
for k, v in replacement.items():
text = text.replace(k, v)
### extract keywords
custom_kw_extractor = yake.KeywordExtractor(lan=language, n=max_ngram_size, dedupLim=deduplication_threshold,
dedupFunc=deduplication_algo, windowsSize=window_size,
top=num_of_keywords, features=None)
return {"keywords": custom_kw_extractor.extract_keywords(text)}

### Keep the longest keyword of if there is an overlap between two keywords.
keywords = custom_kw_extractor.extract_keywords(text)
keywords = self.keep_largest_overlapped_keywords(keywords)
return {"keywords": keywords}

def get_params(self, message: schemas.Message) -> dict:
params = {
"text": message.body.text,
"language": message.body.parameters.get("language", "en"),
"language": message.body.parameters.get("language", "auto"),
"max_ngram_size": message.body.parameters.get("max_ngram_size", 3),
"deduplication_threshold": message.body.parameters.get("deduplication_threshold", 0.25),
"deduplication_algo": message.body.parameters.get("deduplication_algo", 'seqm'),
Expand Down
1 change: 1 addition & 0 deletions requirements.txt
Original file line number Diff line number Diff line change
Expand Up @@ -24,3 +24,4 @@ numpy==1.26.4
protobuf==3.20.2
openai==1.35.6
anthropic==0.31.1
pycld3==0.22
7 changes: 5 additions & 2 deletions test/lib/model/test_yake_keywords.py
Original file line number Diff line number Diff line change
Expand Up @@ -42,7 +42,10 @@ def test_run_yake_real(self):
})
results = self.yake_model.run_yake(**self.yake_model.get_params(message))
self.assertEqual(results, {"keywords": [('love Meedan', 0.0013670273525686505)]})

def test_keep_largest_overlapped_keywords(self):
keywords_test = [('Alegre', 0),('Alegre', 0),('Timpani', 0), ('Presto Timpani', 0), ('AlegreAlegre', 0), ('Alegre Alegre', 0), ("Presto", 0)]
expected = [('Presto Timpani', 0), ('AlegreAlegre', 0), ('Alegre Alegre', 0)]
self.assertEqual(self.yake_model.keep_largest_overlapped_keywords(keywords_test), expected)
def test_get_params_with_defaults(self):
message = schemas.parse_message({
"body": {
Expand All @@ -51,7 +54,7 @@ def test_get_params_with_defaults(self):
},
"model_name": "yake_keywords__Model"
})
expected = {'text': 'Some Text', 'language': "en", 'max_ngram_size': 3, 'deduplication_threshold': 0.25, 'deduplication_algo': 'seqm', 'window_size': 0, 'num_of_keywords': 10}
expected = {'text': 'Some Text', 'language': "auto", 'max_ngram_size': 3, 'deduplication_threshold': 0.25, 'deduplication_algo': 'seqm', 'window_size': 0, 'num_of_keywords': 10}
self.assertEqual(self.yake_model.get_params(message), expected)

def test_get_params_with_specifics(self):
Expand Down
Loading