5857 – apply_replace_by should save history version and not error if the old_pm does not exist #2163
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sometimes by the time we get to the line where we try to access old_pm.id, old_pm does not exist anymore. Because that line is just for auditing, versioning, we can just add old_pm_id (since we have access to that information)
vasconsaurus
requested review from
caiosba,
melsawy,
DGaffney and
jayjay-w
as code owners
|
Code Climate has analyzed commit 817c080 and detected 0 issues on this pull request. The test coverage on the diff in this pull request is 100.0% (100% is the threshold). This pull request will bring the total coverage in the repository to 100.0% (0.0% change). View more on Code Climate. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
When we run apply_replace_by, we look for the original project media id, but sometimes that doesn't exist anymore.
This only causes an error when we try to save that information to the history versioning. Since we already have access to that original project media id, we can just grab that value and save that information.
References: 5857
How has this been tested?
test "should save history version even if the original project media does not exist anymore":
rails test test/models/project_media_5_test.rb:888Things to pay attention to during code review
Please describe parts of the change that require extra attention during code review, for example:
Checklist