-
Notifications
You must be signed in to change notification settings - Fork 11
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Fixes and changes for the data dashboard backend #2159
Conversation
… for top tags analytics
…ating tipline messages analytics
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
A minor adjustment regarding the rake task to improve execution time
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I recommend implementing a loop based on teams, where each team will have a single query to update the Explainer with a nil value and retrieve the language only once.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
@melsawy , I left it that way because on live there are just around 200 cases... do you think the change is still needed?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
No, I thought we had many explainers on live
Description
Some fixes and changes for the data dashboard backend:
updated_at
instead ofcreated_at
for article tags analytics.sent
andreceived
.top_media_tags
method fromCheckDataPoints
lib in theTeamStatistics
lib.How has this been tested?
Existing tests were updated to cover the changes.
Checklist