Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Keep single quote when normalizing query for keyword search. #2158

Merged
merged 2 commits into from
Dec 16, 2024

Conversation

caiosba
Copy link
Contributor

@caiosba caiosba commented Dec 16, 2024

Description

Similarly to CV2-5672. Adding single quote (') to the list of characters to keep when normalizing query for keyword search.

Fixes: CV2-5808.

How has this been tested?

Unit test added.

Checklist

  • I have performed a self-review of my own code
  • I have added unit and feature tests, if the PR implements a new feature or otherwise would benefit from additional testing
  • I have added regression tests, if the PR fixes a bug
  • I have added logging, exception reporting, and custom tracing with any additional information required for debugging
  • I considered secure coding practices when writing this code. Any security concerns are noted above.
  • I have commented my code in hard-to-understand areas, if any
  • I have made needed changes to the README
  • My changes generate no new warnings
  • If I added a third party module, I included a rationale for doing so and followed our current guidelines

Similarly to other characters, add single quotes to the list of characters to handle when searching by keyword.

Fixes: CV2-5808.
@caiosba caiosba merged commit 0d6bdfe into develop Dec 16, 2024
11 checks passed
@caiosba caiosba deleted the fix/CV2-5808-search-escape-single-quote branch December 16, 2024 13:48
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants