5823 – Prevent an attempted relationship between items across teams #2149
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
vasconsaurus
force-pushed
the
5676-alegre-bot-must-filter-invalid-results
branch
from
a167c7a to
46534fb
Compare
we should add tests in the smooch level
…com:meedan/check-api into 5676-alegre-bot-must-filter-invalid-results
vasconsaurus
force-pushed
the
5676-alegre-bot-must-filter-invalid-results
branch
from
86c7659 to
dba3e81
Compare
DGaffney
reviewed
Dec 10, 2024
app/models/concerns/alegre_v2.rb
Outdated
| def isolate_relevant_context(project_media, result) | ||
| (result["contexts"]||result["context"]).select{|x| ([x["team_id"]].flatten & [project_media.team_id].flatten).count > 0 && !x["temporary_media"]}.first | ||
| def isolate_relevant_context(team_id, result) | ||
| (result["contexts"]||result["context"]).select{|x| ([x["team_id"]].flatten & [team_id].flatten).count > 0 && !x["temporary_media"]}.first |
There was a problem hiding this comment.
probably needs to be [(result["contexts"]||result["context"])].flatten.select.... instead here
vasconsaurus
changed the title
computermacgyver
requested changes
Dec 11, 2024
| response = Bot::Alegre.query_sync_with_params(params, "text") | ||
| results = response['result'].to_a.sort_by{ |result| result['_score'] } | ||
| response = Bot::Alegre.query_sync_with_params(params, "text")["result"].collect{|result| | ||
| result["context"] = Bot::Alegre.isolate_relevant_context(team_id, result) |
There was a problem hiding this comment.
For reasons I don't understand, Explainers appear to be indexed in Alegre with the team slug rather than the team_id. As a result, this won't work.
I think the correction action is to index explainers with team_id, but whatever the solution we need to work that out first.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
Please include a summary of the change and which issue is fixed. Please also include relevant motivation and context – why has this been changed/fixed.
References: CV2-5676, CV2-5823
How has this been tested?
Please describe the tests that you ran to verify your changes. Provide instructions so we can verify the changes. Please describe whether or not you implemented automated tests.
Things to pay attention to during code review
Please describe parts of the change that require extra attention during code review, for example:
Checklist