Remove code related to tipline bot v1 #2006
Open
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Reference: CV2-2550
danielevalverde
requested review from
caiosba,
melsawy,
DGaffney and
jayjay-w
as code owners
caiosba
requested changes
Aug 27, 2024
app/models/bot/smooch.rb
Outdated
Comment on lines
361
to
362
| if self.process_menu_option(message, sm.state.value, app_id) | ||
| # Do nothing else - the action will be executed by "process_menu_option" method |
There was a problem hiding this comment.
I think we still need to keep this if.
…g/CV2-2550-remove-code-related-to-tipline-bot-v-1
|
Is this PR still relevant? |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
Reference: CV2-2550
Things to pay attention to during code review
Searched for is_v2 throughout the codebase and removed all conditions and code that were executed when is_v2 was false
Checklist