-
Notifications
You must be signed in to change notification settings - Fork 11
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
CV2-4794-remove travis.yml for CI #1961
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
@chinelo-obitube I think we should remove the .travis.yml
only when we have all Travis functionality replaced by GitHub Actions, for example:
- Notifications
- Code coverage reporting to Code Climate
They are not in place yet, right?
In other words, I think this should be the last step :)
Notifications already come to slack in the #1959 check-github channel. Monitoring for code climate because it's not specifically tied to travis. Once the jobs finish, I will check for the code climate results. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Looks great, and I also checked the output in GitHub Actions to confirm that coverage is correctly merged and submitted to Code Climate! I just left one minor comment, please fix it before merging. Also, please replace the S3 bucket name as we discussed in the ticket, before merging.
.github/workflows/ci-tests.yml
Outdated
- name: After contract Tests | ||
id: after-tests | ||
|
||
- name: After coverage Test |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
This should be "After Contract Test"
Branch is ready for another review. Changed the tests bucket to a new one. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Great work @chinelo-obitube ! Looks great to me now!
Description
As part of the migration to github actions, we are removing .travis.yml
References: https://meedan.atlassian.net/browse/CV2-4794
How has this been tested?
we now have the workflow in github actions and the tests run on pull requests to develop and on push to master.
Things to pay attention to during code review
Please describe parts of the change that require extra attention during code review, for example:
Checklist