Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

CV2-4794-remove travis.yml for CI #1961

Merged
merged 105 commits into from
Jul 22, 2024
Merged

Conversation

chinelo-obitube
Copy link
Contributor

Description

As part of the migration to github actions, we are removing .travis.yml

References: https://meedan.atlassian.net/browse/CV2-4794

How has this been tested?

we now have the workflow in github actions and the tests run on pull requests to develop and on push to master.

Things to pay attention to during code review

Please describe parts of the change that require extra attention during code review, for example:

  • File FFFF, line LL: This refactoring does this and this. Is it consistent with how it’s implemented elsewhere?
  • Etc.

Checklist

  • I have performed a self-review of my own code
  • I have added unit and feature tests, if the PR implements a new feature or otherwise would benefit from additional testing
  • I have added regression tests, if the PR fixes a bug
  • I have added logging, exception reporting, and custom tracing with any additional information required for debugging
  • I considered secure coding practices when writing this code. Any security concerns are noted above.
  • I have commented my code in hard-to-understand areas, if any
  • I have made needed changes to the README
  • My changes generate no new warnings
  • If I added a third party module, I included a rationale for doing so and followed our current guidelines

Copy link
Contributor

@caiosba caiosba left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@chinelo-obitube I think we should remove the .travis.yml only when we have all Travis functionality replaced by GitHub Actions, for example:

  • Notifications
  • Code coverage reporting to Code Climate

They are not in place yet, right?

In other words, I think this should be the last step :)

@chinelo-obitube
Copy link
Contributor Author

@chinelo-obitube I think we should remove the .travis.yml only when we have all Travis functionality replaced by GitHub Actions, for example:

  • Notifications
  • Code coverage reporting to Code Climate

There are not in place yet, right?

In other words, I think this should be the last step :)

Notifications already come to slack in the #1959 check-github channel. Monitoring for code climate because it's not specifically tied to travis. Once the jobs finish, I will check for the code climate results.

@chinelo-obitube chinelo-obitube requested a review from caiosba July 22, 2024 06:51
Copy link
Contributor

@caiosba caiosba left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks great, and I also checked the output in GitHub Actions to confirm that coverage is correctly merged and submitted to Code Climate! I just left one minor comment, please fix it before merging. Also, please replace the S3 bucket name as we discussed in the ticket, before merging.

- name: After contract Tests
id: after-tests

- name: After coverage Test
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This should be "After Contract Test"

@chinelo-obitube
Copy link
Contributor Author

Branch is ready for another review. Changed the tests bucket to a new one.

@chinelo-obitube chinelo-obitube requested a review from caiosba July 22, 2024 21:29
Copy link
Contributor

@caiosba caiosba left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Great work @chinelo-obitube ! Looks great to me now!

@chinelo-obitube chinelo-obitube merged commit 010019d into develop Jul 22, 2024
10 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants