Fixing: Media headers should work for non-WhatsApp tiplines.

[caiosba]

Description

Only WhatsApp requires template messages. The fix here is to use the regular message type when sending newsletters to non-WhatsApp subscribers.

Fixes CV2.3646.

How has this been tested?

I added a unit test for this case.

Things to pay attention to during code review

Nothing in particular. I renamed a constant for clarity and also removed two lines of code not related to this fix but not required anymore.

Checklist

• I have performed a self-review of my own code
• I have added unit and feature tests, if the PR implements a new feature or otherwise would benefit from additional testing
• I have added regression tests, if the PR fixes a bug
• I have added logging, exception reporting, and custom tracing with any additional information required for debugging
• I considered secure coding practices when writing this code. Any security concerns are noted above.
• I have commented my code in hard-to-understand areas, if any
• I have made needed changes to the README
• My changes generate no new warnings
• If I added a third party module, I included a rationale for doing so and followed our current guidelines

[codeclimate]

Code Climate has analyzed commit b8e2aae and detected 0 issues on this pull request.

The test coverage on the diff in this pull request is 100.0% (100% is the threshold).

This pull request will bring the total coverage in the repository to 99.7% (0.0% change).

View more on Code Climate.