Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fixing "PG::UntranslatableCharacter" error when storing some Pender data annotations #1657

Merged
merged 2 commits into from
Sep 16, 2023

Conversation

caiosba
Copy link
Contributor

@caiosba caiosba commented Sep 15, 2023

Description

PostgreSQL doesn't support null characters in a JSON column, so these characters need to be removed before storing.

Fixes CV2-3582.

How has this been tested?

TDD. I added a unit test for this case.

Checklist

  • I have performed a self-review of my own code
  • I have added unit and feature tests, if the PR implements a new feature or otherwise would benefit from additional testing
  • I have added regression tests, if the PR fixes a bug
  • I have added logging, exception reporting, and custom tracing with any additional information required for debugging
  • I considered secure coding practices when writing this code. Any security concerns are noted above.
  • I have commented my code in hard-to-understand areas, if any
  • I have made needed changes to the README
  • My changes generate no new warnings
  • If I added a third party module, I included a rationale for doing so and followed our current guidelines

…ata annotations.

PostgreSQL doesn't support null characters in a JSON column, so these characters need to be removed before storing.

Fixes CV2-3582.
@caiosba caiosba requested a review from melsawy as a code owner September 15, 2023 14:40
@caiosba caiosba requested a review from DGaffney as a code owner September 15, 2023 16:40
@codeclimate
Copy link

codeclimate bot commented Sep 15, 2023

Code Climate has analyzed commit 654b497 and detected 0 issues on this pull request.

The test coverage on the diff in this pull request is 100.0% (100% is the threshold).

This pull request will bring the total coverage in the repository to 99.6% (-0.1% change).

View more on Code Climate.

Copy link
Contributor

@melsawy melsawy left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Good catch Dr Caio
Thanks for fixing this one

@caiosba caiosba merged commit 1ff3a22 into develop Sep 16, 2023
@caiosba caiosba deleted the fix/CV2-3582-pg-untranslatable-character branch September 16, 2023 20:24
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants