Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Automatically install tipline in v2 when workspace is created. #1656

Conversation

caiosba
Copy link
Contributor

@caiosba caiosba commented Sep 14, 2023

Description

  • Set default as true for the Smooch Bot, this way it's installed automatically for all new workspaces
  • Bump to v2 automatically when Smooch Bot is installed

Refences: CV2-833 and CV2-3558.

How has this been tested?

Existing tests should pass. When running the application, this can be tested this way:

  • Create a new workspace
  • Go to the "Tipline" tab: It should be installed and display the v2 settings UI

Checklist

  • I have performed a self-review of my own code
  • I have added unit and feature tests, if the PR implements a new feature or otherwise would benefit from additional testing
  • I have added regression tests, if the PR fixes a bug
  • I have added logging, exception reporting, and custom tracing with any additional information required for debugging
  • I considered secure coding practices when writing this code. Any security concerns are noted above.
  • I have commented my code in hard-to-understand areas, if any
  • I have made needed changes to the README
  • My changes generate no new warnings
  • If I added a third party module, I included a rationale for doing so and followed our current guidelines

* Set `default` as `true` for the Smooch Bot, this way it's installed automatically for all new workspaces
* Bump to v2 automatically when Smooch Bot is installed

Refences: CV2-833 and CV2-3558.
@caiosba caiosba requested a review from melsawy as a code owner September 14, 2023 21:20
@@ -985,6 +985,7 @@ def setup_smooch_bot(menu = false, extra_settings = {})
})
end
@installation = create_team_bot_installation user_id: @bot.id, settings: @settings.merge(extra_settings), team_id: @team.id
@installation.set_smooch_version = 'v1' ; @installation.save!
Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This is not a typo, it's for the v1 tests.

@codeclimate
Copy link

codeclimate bot commented Sep 15, 2023

Code Climate has analyzed commit fe94e28 and detected 0 issues on this pull request.

The test coverage on the diff in this pull request is 100.0% (100% is the threshold).

This pull request will bring the total coverage in the repository to 99.7% (0.0% change).

View more on Code Climate.

@caiosba caiosba merged commit 8c0737d into develop Sep 16, 2023
8 checks passed
@caiosba caiosba deleted the feature/CV2-3558-CV2-833-tipline-bot-v2-automatically-installed branch September 16, 2023 20:24
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants