Do not crash when calculating number of items in a list that has an invalid team task filter #1653
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…nvalid team task filter. I noticed it happening on live only for duplicated workspaces. When a list has a team task filter that doesn't have a valid ID, an exception would happen. I was able to reproduce that exception in a unit test. The fix was to discard the team task filter if the ID is blank. Fixes CV2-3742.
melsawy
requested changes
Sep 14, 2023
| @@ -488,8 +488,8 @@ def file_filter | |||
|
|
|||
| def team_tasks_conditions | |||
| conditions = [] | |||
| return conditions unless @options.has_key?('team_tasks') && @options['team_tasks'].class.name == 'Array' | |||
| @options['team_tasks'].delete_if{ |tt| tt['response'].blank? } | |||
| return conditions unless @options['team_tasks'].class.name == 'Array' | |||
There was a problem hiding this comment.
why did you remove @options.has_key?('team_tasks') from unless condition?
I think we should keep it and only update delete_if to include tt['id'].blank?
There was a problem hiding this comment.
@melsawy because I think it's redundant with @options['team_tasks'].class.name ... if there is no team_tasks key, @options['team_tasks'].class.name is going to return NilClass
|
Code Climate has analyzed commit 4a1b997 and detected 0 issues on this pull request. The test coverage on the diff in this pull request is 100.0% (100% is the threshold). This pull request will bring the total coverage in the repository to 99.7% (0.0% change). View more on Code Climate. |
melsawy
approved these changes
Sep 14, 2023
caiosba
deleted the
fix/CV2-3742-empty-team-task-filter-for-list-counter
branch
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
I noticed it happening on live only for duplicated workspaces. When a list has a team task filter that doesn't have a valid ID, an exception would happen. I was able to reproduce that exception in a unit test.
The fix was to discard the team task filter if the ID is blank.
Fixes CV2-3742.
How has this been tested?
TDD. I was able to implement a unit test that reproduced the issue.
Checklist