Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

CV2-3589 add language as a parameter for import_claim_reviews #1652

Merged
merged 3 commits into from
Sep 14, 2023

Conversation

DGaffney
Copy link
Contributor

Description

Adds a language parameter to import_claim_reviews, and passes that along to fetch, which already supports it.

References: 3589

How has this been tested?

I've tested the fetch side of this, and this update is simply a passthrough to allow for using that functionality.

Things to pay attention to during code review

Nothing particularly exciting here.

Checklist

  • I have performed a self-review of my own code
  • I have added unit and feature tests, if the PR implements a new feature or otherwise would benefit from additional testing
  • I have added regression tests, if the PR fixes a bug
  • I have added logging, exception reporting, and custom tracing with any additional information required for debugging
  • I have commented my code in hard-to-understand areas, if any
  • I have made needed changes to the README
  • My changes generate no new warnings
  • If I added a third party module, I included a rationale for doing so and followed our current guidelines

Copy link
Contributor

@computermacgyver computermacgyver left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks! I've read through and searched for all uses of import_claim_reviews in the codebase, and this looks good to me.

@codeclimate
Copy link

codeclimate bot commented Sep 14, 2023

Code Climate has analyzed commit 7a77932 and detected 0 issues on this pull request.

The test coverage on the diff in this pull request is 100.0% (100% is the threshold).

This pull request will bring the total coverage in the repository to 99.6% (-0.1% change).

View more on Code Climate.

@DGaffney DGaffney marked this pull request as ready for review September 14, 2023 17:32
@DGaffney DGaffney merged commit 9681fa6 into develop Sep 14, 2023
8 checks passed
@DGaffney DGaffney deleted the cv2-3589-import-with-language branch September 14, 2023 17:32
caiosba pushed a commit that referenced this pull request Sep 14, 2023
* CV2-3589 add language as a parameter for import_claim_reviews

* CV2-3589 refactor to not uselessly explode all the tests and rewrite them with a meaningless null value

* fix small oversight
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants