Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

CV2-3177: fix newsletter validation #1649

Conversation

melsawy
Copy link
Contributor

@melsawy melsawy commented Sep 11, 2023

Description

Fix errors and validation for enabled newsletter.

References: CV2-3177

How has this been tested?

Implemented automated tests .

Checklist

  • I have performed a self-review of my own code
  • I have added unit and feature tests, if the PR implements a new feature or otherwise would benefit from additional testing
  • I have added regression tests, if the PR fixes a bug
  • I have added logging, exception reporting, and custom tracing with any additional information required for debugging
  • I have commented my code in hard-to-understand areas, if any
  • I have made needed changes to the README
  • My changes generate no new warnings
  • If I added a third party module, I included a rationale for doing so and followed our current guidelines

@melsawy melsawy marked this pull request as ready for review September 12, 2023 05:21
@melsawy melsawy requested a review from caiosba as a code owner September 12, 2023 05:21
@codeclimate
Copy link

codeclimate bot commented Sep 12, 2023

Code Climate has analyzed commit 47b3522 and detected 0 issues on this pull request.

The test coverage on the diff in this pull request is 100.0% (100% is the threshold).

This pull request will bring the total coverage in the repository to 99.7% (0.0% change).

View more on Code Climate.

@melsawy melsawy merged commit 0f14239 into develop Sep 12, 2023
8 checks passed
@melsawy melsawy deleted the fix/CV2-3177-users-should-be-able-to-save-newsletters-that-arent-ready-to-go-out branch September 12, 2023 16:06
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants