Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

CV2-3684: refactor update status mutation #1642

Draft
wants to merge 1 commit into
base: develop
Choose a base branch
from
Draft

CV2-3684: refactor update status mutation #1642

wants to merge 1 commit into from

Conversation

melsawy
Copy link
Contributor

@melsawy melsawy commented Aug 29, 2023

Description

Please include a summary of the change and which issue is fixed. Please also include relevant motivation and context – why has this been changed/fixed.

References: TICKET-ID, TICKET-ID, …

How has this been tested?

Please describe the tests that you ran to verify your changes. Provide instructions so we can verify the changes. Please describe whether or not you implemented automated tests.

Things to pay attention to during code review

Please describe parts of the change that require extra attention during code review, for example:

  • File FFFF, line LL: This refactoring does this and this. Is it consistent with how it’s implemented elsewhere?
  • Etc.

Checklist

  • I have performed a self-review of my own code
  • I have added unit and feature tests, if the PR implements a new feature or otherwise would benefit from additional testing
  • I have added regression tests, if the PR fixes a bug
  • I have added logging, exception reporting, and custom tracing with any additional information required for debugging
  • I have commented my code in hard-to-understand areas, if any
  • I have made needed changes to the README
  • My changes generate no new warnings
  • If I added a third party module, I included a rationale for doing so and followed our current guidelines

codeclimate[bot]
codeclimate bot reviewed Aug 29, 2023
View reviewed changes
Copy link

@codeclimate codeclimate bot left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

The PR diff size of 10737 lines exceeds the maximum allowed for the inline comments feature.

@codeclimate
Copy link

codeclimate bot commented Aug 29, 2023

Code Climate has analyzed commit 1e02bb2 and detected 0 issues on this pull request.

The test coverage on the diff in this pull request is 100.0% (100% is the threshold).

This pull request will bring the total coverage in the repository to 99.7% (0.0% change).

View more on Code Climate.

@caiosba
Copy link
Contributor

caiosba commented Dec 11, 2024

Is this PR still relevant?

@melsawy
Copy link
Contributor Author

melsawy commented Dec 16, 2024

@caiosba I initiated this PR to provide the implementation steps for using the UpdateStatus mutation instead of UpdateDynamic for future use with tags and other annotation types.

so I believe it's safe to close it.

@caiosba
Copy link
Contributor

caiosba commented Dec 16, 2024

OK, please close it then :)

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@codeclimate codeclimate[bot] codeclimate[bot] left review comments

@caiosba caiosba Awaiting requested review from caiosba caiosba will be requested when the pull request is marked ready for review caiosba is a code owner

@DGaffney DGaffney Awaiting requested review from DGaffney DGaffney will be requested when the pull request is marked ready for review DGaffney is a code owner

@jayjay-w jayjay-w Awaiting requested review from jayjay-w jayjay-w will be requested when the pull request is marked ready for review jayjay-w is a code owner

At least 1 approving review is required to merge this pull request.

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@melsawy @caiosba