Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

CV2-5050 re-embed item on add event #465

Merged
merged 6 commits into from
Oct 31, 2024
Merged

CV2-5050 re-embed item on add event #465

merged 6 commits into from
Oct 31, 2024

Conversation

DGaffney
Copy link
Contributor

Description

add_item needs to be embedded with an "item" key in order to play nicely with check-api
Reference: CV2-5050

How has this been tested?

Relevant local tests appear to pass here, extremely minor tweaks if any are needed.

Have you considered secure coding practices when writing this code?

None

app/main/lib/similarity.py Outdated Show resolved Hide resolved
@DGaffney DGaffney requested review from dmou and caiosba October 31, 2024 13:56
@DGaffney DGaffney marked this pull request as ready for review October 31, 2024 14:08
@DGaffney DGaffney merged commit 83e6360 into develop Oct 31, 2024
4 checks passed
@DGaffney DGaffney deleted the cv2-5050-fix-item branch October 31, 2024 14:49
Copy link

sentry-io bot commented Nov 4, 2024

Suspect Issues

This pull request was deployed and Sentry observed the following issues:

  • ‼️ RequestError: RequestError(400, 'mapper_parsing_exception', "failed to parse field [vector_paraphrase-multiling... api.presto_presto_resource View Issue

Did you find this useful? React with a 👍 or 👎

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants