Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

CHECK-2355 Remove platform dependencies to support deployment to ARM servers #254

Draft
wants to merge 2 commits into
base: develop
Choose a base branch
from

Conversation

huslage
Copy link
Contributor

@huslage huslage commented Sep 1, 2022

We need to support deployment to ARM-based servers and Macs. This is the work to de-platform the code.

@huslage huslage marked this pull request as draft September 1, 2022 15:07
@codeclimate
Copy link

codeclimate bot commented Sep 1, 2022

Code Climate has analyzed commit 3ee5332 and detected 0 issues on this pull request.

The test coverage on the diff in this pull request is 100.0% (50% is the threshold).

This pull request will bring the total coverage in the repository to 88.7% (0.0% change).

View more on Code Climate.

@huslage
Copy link
Contributor Author

huslage commented Sep 2, 2022

@DGaffney @computermacgyver I'm getting this error when it tries to install tmkpy:

#0 354.3   │ exit code: 1
#0 354.3   ╰─> [29 lines of output]
#0 354.3       running install
#0 354.3       /usr/local/lib/python3.9/site-packages/setuptools/command/install.py:34: SetuptoolsDeprecationWarning: setup.py install is deprecated. Use build and pip and other standards-based tools.
#0 354.3         warnings.warn(
#0 354.3       running build
#0 354.3       running build_py
#0 354.3       make: 'libtmk.a' is up to date.
#0 354.3       creating build
#0 354.3       creating build/lib.linux-aarch64-cpython-39
#0 354.3       copying tmkpy.py -> build/lib.linux-aarch64-cpython-39
#0 354.3       running build_ext
#0 354.3       building '_tmkpy' extension
#0 354.3       swigging tmkpy.i to tmkpy_wrap.cpp
#0 354.3       swig -python -c++ -o tmkpy_wrap.cpp tmkpy.i
#0 354.3       creating build/temp.linux-aarch64-cpython-39
#0 354.3       gcc -pthread -Wno-unused-result -Wsign-compare -DNDEBUG -g -fwrapv -O3 -Wall -fPIC -I. -I/usr/local/include/python3.9 -c tmkpy.cpp -o build/temp.linux-aarch64-cpython-39/tmkpy.o
#0 354.3       tmkpy.cpp: In function ‘facebook::tmk::algo::TMKFeatureVectors hashVideo(std::string, std::string)’:
#0 354.3       tmkpy.cpp:36:7: warning: unused variable ‘rc’ [-Wunused-variable]
#0 354.3          36 |  bool rc = facebook::tmk::hashing::hashVideoFile(
#0 354.3             |       ^~
#0 354.3       tmkpy.cpp: In function ‘std::vector<float> query(facebook::tmk::algo::TMKFeatureVectors, std::vector<std::__cxx11::basic_string<char> >, int)’:
#0 354.3       tmkpy.cpp:106:17: warning: comparison of integer expressions of different signedness: ‘int’ and ‘std::vector<std::__cxx11::basic_string<char> >::size_type’ {aka ‘long unsigned int’} [-Wsign-compare]
#0 354.3         106 |   if (numThreads>haystackFilenames.size()) {
#0 354.3             |       ~~~~~~~~~~^~~~~~~~~~~~~~~~~~~~~~~~~
#0 354.3       gcc -pthread -Wno-unused-result -Wsign-compare -DNDEBUG -g -fwrapv -O3 -Wall -fPIC -I. -I/usr/local/include/python3.9 -c tmkpy_wrap.cpp -o build/temp.linux-aarch64-cpython-39/tmkpy_wrap.o
#0 354.3       g++ -pthread -shared build/temp.linux-aarch64-cpython-39/tmkpy.o build/temp.linux-aarch64-cpython-39/tmkpy_wrap.o -Ltmk/cpp/ -L/usr/local/lib -ltmk -o build/lib.linux-aarch64-cpython-39/_tmkpy.cpython-39-aarch64-linux-gnu.so
#0 354.3       /usr/bin/ld: skipping incompatible tmk/cpp//libtmk.a when searching for -ltmk
#0 354.3       /usr/bin/ld: cannot find -ltmk
#0 354.3       collect2: error: ld returned 1 exit status
#0 354.3       error: command '/usr/bin/g++' failed with exit code 1
#0 354.3       [end of output]
#0 354.3   
#0 354.3   note: This error originates from a subprocess, and is likely not a problem with pip.
#0 354.3 error: legacy-install-failure```

@huslage huslage changed the title Remove platform dependencies to support deployment to ARM servers CHECK-2355 Remove platform dependencies to support deployment to ARM servers Sep 2, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant