Add continuation packet support #115
Open
+556
−250
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
- Add header properties to the RawPacketData class that can be used to look up the values directly from the bytes object. - Add a create_ccsds_packet function that takes in integers for the header items and packs them for users. Especially useful for creating test data packets.
…arsing Create a separate CCSDS packet generator that is dedicated to handling the input data and yielding individual packets. The parsing functions then utilize this generator to handle the actual data parsing.
These are unused now that the packet itself can be used to get the previously parsed values.
When combining continuation packets the first packet's header (and potentially secondary_header) are kept and only the data field of subsequent packets are concatenated onto the first. packet1header, packet1secondary, packet1data, packet2data, packet3data, ...
greglucas
force-pushed
the
continuation-packets
branch
from
f404a40 to
6212a8d
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This builds on the packet refactor work (the final commit of this PR is relevant to continuation packets) and adds continuation packet support to the XTCE parsing and packet generation. This adds logic to concatenate packet data fields together across successive packets (if there was too much data to fit in a single CCSDS packet or it was logically better to split by other teams).
definition.packet_generator(data, combine_segmented_packets=True, secondary_header_bytes=4)Notes:
combine_segmented_packets=False, so this is opt-in behavior. I'm not sure if that is what we should do or if we should start combining them right away and have it be opt-out instead?closes #114
Checklist