Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

34 dockerisation and ci build #40

Merged
merged 31 commits into from
Aug 27, 2024
Merged

34 dockerisation and ci build #40

merged 31 commits into from
Aug 27, 2024

Conversation

juliangruendner
Copy link
Contributor

No description provided.

Lucas0T and others added 29 commits July 4, 2024 11:40
Milestone 0.0.3 with
Flare Endpoint and Integration Tests

Signed-off-by: Lucas Triefenbach <[email protected]>
Milestone 0.0.3 with
Flare Endpoint and Integration Tests

Signed-off-by: Lucas Triefenbach <[email protected]>
# Conflicts:
#	src/main/java/de/medizininformatikinitiative/torch/util/Redaction.java
# Conflicts:
#	pom.xml
#	src/main/java/de/medizininformatikinitiative/torch/rest/FhirController.java
#	src/main/java/de/medizininformatikinitiative/torch/util/ElementCopier.java
#	src/main/java/de/medizininformatikinitiative/torch/util/Redaction.java
#	src/main/resources/application.yml
#	src/test/java/de/medizininformatikinitiative/torch/CrtdlTest.java
#	src/test/resources/application.yml
@juliangruendner juliangruendner linked an issue Aug 26, 2024 that may be closed by this pull request
Copy link
Contributor

@Lucas0T Lucas0T left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Seems to be working, will handle async next.

@github-advanced-security
Copy link

This pull request sets up GitHub code scanning for this repository. Once the scans have completed and the checks have passed, the analysis results for this pull request branch will appear on this overview. Once you merge this pull request, the 'Security' tab will show more code scanning analysis results (for example, for the default branch). Depending on your configuration and choice of analysis tool, future pull requests will be annotated with code scanning analysis results. For more information about GitHub code scanning, check out the documentation.

@Lucas0T Lucas0T merged commit 10d5619 into main Aug 27, 2024
2 checks passed
//Set of PatIds that survived the
Set<String> safeGroup = new HashSet<>();
List<String> batches = splitListIntoBatches(patients, batchSize);
logger.debug("FHIR search List size for group {}: {}", group, batches.size());

Check notice

Code scanning / CodeQL

Use of default toString() Note

Default toString(): AttributeGroup inherits toString() from Object, and so is not suitable for printing.
}

@Bean
public ResourceTransformer resourceTransformer(DataStore dataStore, ElementCopier copier, Redaction redaction, CdsStructureDefinitionHandler cds, FhirContext context) {

Check notice

Code scanning / CodeQL

Useless parameter Note

The parameter 'copier' is never used.
}

@Bean
public ResourceTransformer resourceTransformer(DataStore dataStore, ElementCopier copier, Redaction redaction, CdsStructureDefinitionHandler cds, FhirContext context) {

Check notice

Code scanning / CodeQL

Useless parameter Note

The parameter 'redaction' is never used.
}

@Bean
public ResourceTransformer resourceTransformer(DataStore dataStore, ElementCopier copier, Redaction redaction, CdsStructureDefinitionHandler cds, FhirContext context) {

Check notice

Code scanning / CodeQL

Useless parameter Note

The parameter 'context' is never used.
result.append(".").append(sliceParts[1]);
}else {
String sliceName = sliceParts[1].replace(path, "");
Base element;

Check notice

Code scanning / CodeQL

Unread local variable Note

Variable 'Base element' is never read.
} catch (NullPointerException ex) {

logger.error(" Child Type Unknown {}", childID,child.getName());

Check warning

Code scanning / CodeQL

Unused format argument Warning

This format call refers to 1 argument(s) but supplies 2 argument(s).
@Test
public void testMustHave() throws IOException {

FileInputStream fis = new FileInputStream(RESOURCE_PATH_PREFIX+"CRTDL/CRTDL_observation_must_have.json");

Check warning

Code scanning / CodeQL

Potential input resource leak Warning test

This FileInputStream is not always closed on method exit.

@Test
public void testFlare() throws IOException {
FileInputStream fis = new FileInputStream("src/test/resources/CRTDL/CRTDL_diagnosis_female.json");

Check warning

Code scanning / CodeQL

Potential input resource leak Warning test

This FileInputStream is not always closed on method exit.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Dockerisation and CI build
2 participants