Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Only finalize an encoding when all chunks have finished #938

Open
wants to merge 2 commits into
base: main
Choose a base branch
from
Open

Only finalize an encoding when all chunks have finished #938

Changes from all commits
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
04ee928
Only finalize an encoding when all chunks have finished
KyleMaas Dec 15, 2023
5ec70ad
Account for failed chunks in completeness checks
KyleMaas Dec 21, 2023
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
2 changes: 1 addition & 1 deletion files/models.py
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -1478,7 +1478,7 @@ def encoding_file_save(sender, instance, created, **kwargs):
break

for chunk in chunks:
if not (chunk.media_file and chunk.media_file.path):
if not (chunk.media_file and chunk.media_file.path) or not (chunk.status in ["fail", "success"]):
complete = False
break

Expand Down
Loading