Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Wrap logo in h1 tag for search engines and screenreaders #552

Open
wants to merge 4 commits into
base: main
Choose a base branch
from

Conversation

KyleMaas
Copy link
Contributor

Description

This adds an <h1> tag around the logo in the header, mainly to help search engines and screenreaders find the name of the site, since the rest of the page was missing header information.

Steps

Pre-deploy

cd frontend
npm run dist
cp -ra dist/static/* ../static/

Post-deploy

@KyleMaas
Copy link
Contributor Author

Also added static indexable links for the nav menu.

<div id="app-sidebar">
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Why are you adding these at that place? I think it's better to avoid bringing all of them here for a number of reason (they might be removed by some installations, or even the URLs changed etc)

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Mainly because that's where they are generated in the frontend, so when they're replaced during load, the markup is similar. This means it's compatible with the existing stylesheet to prevent it from blinking and rearranging as the page progressively loads on slower connections. The differences from the final frontend-generated version also mean that any search engines indexing the page which do partially evaluate JavaScript (such as Google) don't ding you for presenting something different to users than what the search engine sees.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants