Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[ITKGDCM] debug ITK GDCM reader for DICOM #1138

Draft
wants to merge 1 commit into
base: master
Choose a base branch
from

Conversation

mathildemerle
Copy link
Collaborator

This PR is a draft to share with @Florent2305 and @juliencastelneau to adapt with their work.

This PR:

  • Debug itkGDCMDataImageReader (from medInria) which uses directly itk::GDCMImageIO (from ITK) to read DICOM.
  • Remove for now itkDCMTKDataImageReader and itkDCMTKImageIO which are both from medInria. In ITK there are itkDCMTKImageIO files compiled with Module_ITKIODCMTK at ON at ITK compilation. I tried to use this module by the way but there are not so much documentation about this ITK external module, ITKGDCM is there by default, so for now i just removed the DCMTK part from medInria to switch to GDCM. At one point (for the data sources for instance), we could add back a cleaned ITKDCMTK reader for instance. Or we could keep the previous ITKDCMTKReader and itkDCMTKImageIO in medInria, but maybe itkDCMTKImageIO could be enhanced. We'll see.

Small note: it's a draft, i did not tried on many DICOMs. It does not read DICOMDIR (as for itkDCMTKReader) fo instance, but it's a beginning.
Small note²: it seems that the DICOM code for AcquisitionTime and AcquisitionDate was switched in itkDCMTKReader.
Small note yet again: we really should avoid files in medInria beginning by the name of one of our external lib, like ITK. It creates confusion when we think that a file is from ITK but is internal :D.

Ⓜ️

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant