Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[macOS] solve package error if packaging failed before #1104

Open
wants to merge 1 commit into
base: master
Choose a base branch
from

Conversation

mathildemerle
Copy link
Collaborator

Fix #1103
Based on #1096 which is needed

Commit: bf5665d

On macOS, if you stopped a packaging step, or if it failed, the current volume as "/Volumes/medInria 4.0.0" was not removed. That's something i needed to check and remove on MUSICardio Jenkins in a script before the compilation/packaging of the application. But it was not done in medInria.

This commit:

  • removes spaces in volume names since it creates problem in the script under zsh
  • checks previous failed medInria volumes and removes them
  • moves BaseMedinriaPackage.sparseimage.gz in packaging/apple (and not in src/utils/osx_packaging)

Ⓜ️

@mathildemerle mathildemerle added this to the 4.0 milestone Feb 14, 2023
Copy link
Member

@Florent2305 Florent2305 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Ok

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

[medInria4] empty zip/dmg packages on master branch
2 participants