Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[Custom] configure setting file to customize medInria #1094

Open
wants to merge 5 commits into
base: master
Choose a base branch
from

Conversation

mathildemerle
Copy link
Collaborator

The commit : f05491a
PR based on PR 1090 and #1091

One of the goals of medInria4 is an easy customization of the app for external projects using medInria.

The customization system

This PR adds a settings.json file at root of medInria, set for medInria default "style": name, description, icons, logos, release notes, etc. CMake reads this json file and extracts the information, passes them also to medInria c++ parts. These values allow to configure the application.

I added a medInria version of the logo for light background/theme.

This settings file can be adapted as i did for MUSICardio. The devs of an external project of medInria, can create their own repo with dedicated info, to access the settings files easily.

For instance to compile med4 with a rebranding

  • git clone medInria4
  • enter medInria4, git clone customization repo
  • replace the settings file at root of medInria by the one from the customization directory
  • build the application

What remains to be done

  • i tested on Ubuntu 20.04. I/we need to test on the other platforms
  • Specifically on macOS there is the dmg style problem which remains: [dmg] modularity of dmg design #866. I added this system in MUSICardio but it needs to be tested and adapted to medInria configuration

Ⓜ️

@mathildemerle mathildemerle added this to the 4.0 milestone Feb 6, 2023
@mathildemerle mathildemerle changed the title [Custom] configure setting file to customize medInria 4 [Custom] configure setting file to customize medInria Nov 27, 2024
Copy link
Member

@Florent2305 Florent2305 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

We must keep this code base but, I don't agree to merge it directly.
I would like to create a new PR based on this one, with changes concerning the CMake part.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants