Use Moodle 4.5 Core AI subsystem #5
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Conditionally use tool_aiconnect or moodle 4.5 coreai subsystem A new function called perform_request checks the usemebisai setting and if it is set then the mebis-lp ai subsystem is used, otherwise the Core AI subsystem is used. The tool_aiconnect approach has been removed
PM84
commented
Nov 4, 2024
PM84
commented
Nov 4, 2024
PM84
commented
Nov 4, 2024
| $settings->add(new admin_setting_configcheckbox( | ||
| 'qtype_aitext/usemebisai', | ||
| new lang_string('usemebis_ai', 'qtype_aitext'), | ||
| new lang_string('usemebis_ai_setting', 'qtype_aitext'), |
There was a problem hiding this comment.
Suggested change
| new lang_string('usemebis_ai_setting', 'qtype_aitext'), | |
| new lang_string('use_local_ai_manager_setting', 'qtype_aitext'), |
PM84
commented
Nov 4, 2024
| @@ -66,6 +66,12 @@ | |||
| new lang_string('responseformat_setting', 'qtype_aitext'), | |||
| 0, ['plain' => 'plain', 'editor' => 'editor', 'monospaced' => 'monospaced'] | |||
| )); | |||
| $settings->add(new admin_setting_configcheckbox( | |||
| 'qtype_aitext/usemebisai', | |||
| new lang_string('usemebis_ai', 'qtype_aitext'), | |||
There was a problem hiding this comment.
Suggested change
| new lang_string('usemebis_ai', 'qtype_aitext'), | |
| new lang_string('use_local_ai_manager', 'qtype_aitext'), |
PM84
commented
Nov 4, 2024
| @@ -66,6 +66,12 @@ | |||
| new lang_string('responseformat_setting', 'qtype_aitext'), | |||
| 0, ['plain' => 'plain', 'editor' => 'editor', 'monospaced' => 'monospaced'] | |||
| )); | |||
| $settings->add(new admin_setting_configcheckbox( | |||
| 'qtype_aitext/usemebisai', | |||
There was a problem hiding this comment.
Suggested change
| 'qtype_aitext/usemebisai', | |
| 'qtype_aitext/uselocalaimanager', |
PM84
commented
Nov 4, 2024
| @@ -143,6 +143,41 @@ public function compute_final_grade($responses, $totaltries) { | |||
| public function apply_attempt_state(question_attempt_step $step) { | |||
| $this->step = $step; | |||
| } | |||
| /** | |||
| * Call the llm using either the 4.5 core api | |||
| * or the the mebis ai depending on the usemebisai | |||
There was a problem hiding this comment.
Suggested change
| * or the the mebis ai depending on the usemebisai | |
| * or the the mebis ai depending on the uselocalaimanager |
PM84
commented
Nov 4, 2024
| * @return string $response | ||
| */ | ||
| public function perform_request(string $prompt, string $purpose): string { | ||
| if (get_config('qtype_aitext', 'usemebisai')) { |
There was a problem hiding this comment.
Suggested change
| if (get_config('qtype_aitext', 'usemebisai')) { | |
| if (get_config('qtype_aitext', 'uselocalaimanager')) { |
PM84
commented
Nov 4, 2024
There was a problem hiding this comment.
Hi Marcus,
we would like the local_ai_manager itself to be named there rather than “mebis”.
Apart from that, I don't see any problems that would prevent us from merging our forums.
However, we will make a few minor changes. We can then contribute them directly to you.
|
This is excellent |
|
closed in favor of #6 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Conditionally use tool_aiconnect or moodle 4.5 coreai subsystem A new function called perform_request checks the usemebisai setting and if it is set then the mebis-lp ai subsystem is used, otherwise the Core AI subsystem is used. The tool_aiconnect approach has been removed