MBS-8967: Add modal to show errors when trying to change sth #46
Conversation
|
Failing GHA is not related to this PR |
There was a problem hiding this comment.
This fixes part of the issue when trying to do for example things you aren't allowed to.
However, the error handling should be implemented for every webservices call, also for the permanent update polls for example. Currently, if for testing purposes I insert an exception into get_kanban_content_update the app will just crash.
The error handling should properly handle the issue of connection loss.
Maybe it's also possible/easier to use displayException function?
|
Added an alert for displaying connection loss. |
amd/src/mutations.js
Outdated
| * @param {*} ex | ||
| */ | ||
| processFail(ex) { | ||
| Notification.alert(getString('error'), ex.message, getString('cancel')); |
There was a problem hiding this comment.
alert is an async function, it needs to be called with await
PhMemmel
force-pushed
the
MBS-8967-error-handling
branch
from
b44e867 to
5791dad
Compare
sh-csg
force-pushed
the
MBS-8967-error-handling
branch
from
068d9ff to
5afced9
Compare
There was a problem hiding this comment.
Seems to work well so far, good job!
Would it be difficult to implement a feedback for actions the user is doing? If he tries to create a card for example there is no feedback if this action is being queued or it's just being ignored or what happens with it.
Another solution would be to disable the UI completely until the connection is back up.
Thoughts?
Implements #14