MBS-8974: Unit test fix

mebis-lp · Dec 16, 2024 · 407902d · 407902d
1 parent 6311c8b
commit 407902d
Show file tree

Hide file tree

Showing 3 changed files with 7 additions and 4 deletions.
diff --git a/classes/boardmanager.php b/classes/boardmanager.php
@@ -683,7 +683,7 @@ public function set_card_complete(int $cardid, int $state): void {
         $assignees = $this->get_card_assignees($cardid);
         if ($state) {
             helper::remove_calendar_event($this->kanban, $card, $assignees);
-            if ($card->repeat_enable) {
+            if (!empty($card->repeat_enable)) {
                 $newcard = clone $card;
                 if ($card->repeat_newduedate == constants::MOD_KANBAN_REPEAT_NONEWDUEDATE) {
                     $newcard->duedate = 0;

diff --git a/classes/external/change_kanban_content.php b/classes/external/change_kanban_content.php
@@ -299,7 +299,6 @@ public static function move_card_returns(): external_single_structure {
      * @throws moodle_exception
      */
     public static function move_card(int $cmid, int $boardid, array $data): array {
-        global $USER;
         $params = self::validate_parameters(self::move_card_parameters(), [
             'cmid' => $cmid,
             'boardid' => $boardid,

diff --git a/tests/change_kanban_content_test.php b/tests/change_kanban_content_test.php
@@ -263,10 +263,12 @@ public function test_move_card(): void {
 
         $update = json_decode($returnvalue['update'], true);
 
-        $this->assertCount(3, $update);
+        // As the target column has autoclose enabled by default, we get two updates for cards.
+        $this->assertCount(4, $update);
         $this->assertEquals('cards', $update[0]['name']);
         $this->assertEquals('columns', $update[1]['name']);
         $this->assertEquals('columns', $update[2]['name']);
+        $this->assertEquals('cards', $update[3]['name']);
 
         $this->assertEquals(join(',', [$cards[0]->id, $cards[2]->id]), $update[2]['fields']['sequence']);
         $this->assertEquals('', $update[1]['fields']['sequence']);
@@ -301,10 +303,12 @@ public function test_move_card(): void {
 
         $update = json_decode($returnvalue['update'], true);
 
-        $this->assertCount(3, $update);
+        // As the target column has autoclose enabled by default, we get two updates for cards.
+        $this->assertCount(4, $update);
         $this->assertEquals('cards', $update[0]['name']);
         $this->assertEquals('columns', $update[1]['name']);
         $this->assertEquals('columns', $update[2]['name']);
+        $this->assertEquals('cards', $update[3]['name']);
 
         $this->assertEquals(join(',', [$cards[2]->id, $cards[1]->id, $cards[0]->id]), $update[2]['fields']['sequence']);
         $this->assertEquals('', $update[1]['fields']['sequence']);