MBS-8543: Option added to pass on WLAN data via QR code #9
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
sh-csg
reviewed
Feb 12, 2024
lang/en/block_qr.php
Outdated
There was a problem hiding this comment.
String wlan_passkey is missing (you see that if hovering over the help icon in the edit form).
| $authenticationoptions = [ | ||
| 'nopass' => get_string('none', 'block_qr'), | ||
| 'WEP' => get_string('wep', 'block_qr'), | ||
| 'WPA/WPA2' => get_string('wpa', 'block_qr'), |
There was a problem hiding this comment.
Maybe encrypted wifi is the more common use case for this option, so this might be the default?
lang/en/block_qr.php
Outdated
There was a problem hiding this comment.
Strings should be in alphabetical order
edit_form.php
Outdated
| @@ -82,7 +82,8 @@ protected function specific_definition($mform) { | |||
| 'internalcontent' => get_string('internalcontent', 'block_qr'), | |||
| 'owncontent' => get_string('owncontent', 'block_qr'), | |||
| 'event' => get_string('event', 'block_qr'), | |||
| 'geolocation' => get_string('geolocation', 'block_qr') | |||
| 'geolocation' => get_string('geolocation', 'block_qr'), | |||
| 'wlan' => get_string('wlan', 'block_qr') | |||
There was a problem hiding this comment.
Comma at the end of a multi-line array
|
Thanks for your feedback. New commits added |
… urlencode() function is called.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.