Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

WIP: Created Listener Service #1

Open
wants to merge 27 commits into
base: master
Choose a base branch
from
Open

WIP: Created Listener Service #1

wants to merge 27 commits into from

Conversation

Shahar-Y
Copy link
Contributor

  • Server connects to mongo via connection string
  • Updates rabbitmq on changes
  • Added winston
  • Docker-compose creates a replicaSet

@Shahar-Y Shahar-Y self-assigned this Sep 21, 2020
nogahaskal
nogahaskal requested changes Sep 22, 2020
View reviewed changes
Copy link

@nogahaskal nogahaskal left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good :)
I will check your package to understand.

Dockerfile Outdated Show resolved Hide resolved
docker-compose.yml Outdated Show resolved Hide resolved
package.json Outdated Show resolved Hide resolved
src/config.ts Outdated Show resolved Hide resolved
src/index.ts Outdated Show resolved Hide resolved
src/index.ts Outdated Show resolved Hide resolved
src/index.ts Outdated Show resolved Hide resolved
tslint.json Show resolved Hide resolved
src/logger.ts Outdated Show resolved Hide resolved
src/logger.ts Outdated Show resolved Hide resolved
@Shahar-Y
fixed pr #1
1b42ab6 
Signed-off-by: shahar-y <[email protected]>
nogahaskal
nogahaskal approved these changes Sep 23, 2020
View reviewed changes
Copy link

@nogahaskal nogahaskal left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thank you for your time.
I was Noga and this was my awesome code review.
Hope to see you in the future.

With great regards, still, Noga

src/index.ts Outdated Show resolved Hide resolved
@Shahar-Y
added middleware
a2f49af 
Signed-off-by: shahar-y <[email protected]>
@Shahar-Y
Copy link
Contributor Author

@nogahaskal please go over the last commit

@Shahar-Y
fix objectTypes
d0346f5 
Signed-off-by: shahar-y <[email protected]>
nogahaskal
nogahaskal previously approved these changes Sep 29, 2020
View reviewed changes
src/utils/middleware.ts Outdated Show resolved Hide resolved
src/utils/middleware.ts Outdated Show resolved Hide resolved
@Shahar-Y Shahar-Y changed the title Created Listener Service WIP: Created Listener Service Oct 13, 2020
@Shahar-Y
Copy link
Contributor Author

Before closing, we need to go over the packages!
@nogahaskal

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@nogahaskal nogahaskal nogahaskal left review comments

@yonatandt yonatandt Awaiting requested review from yonatandt

At least 1 approving review is required to merge this pull request.

Assignees

@Shahar-Y Shahar-Y

Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@Shahar-Y @nogahaskal @nettashviro