Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Support custom events tracking on Android #1142

Draft
wants to merge 17 commits into
base: main
Choose a base branch
from
Draft

Conversation

abhaysood
Copy link
Contributor

@abhaysood abhaysood commented Aug 28, 2024

Description

  • Remove storage of user defined attributes in database
  • Expose Measure.trackEvent as public API.
  • Expose buildAttributes and related classes as public API to allow adding attributes to the event.
  • Implement custom serialization for attributes.
  • Refactor user defined attributes to use Attributes typealias across the code.
  • Remove userDefinedAttributeKeyWithSpaces and add maxUserDefinedAttributesPerEvent as internal configs.
  • Add functional test.
  • Update public API.
  • End to end test when backend is ready.
  • Update documentation.
  • Review how to serialize attribute values and which types to support — int, long, double, float, string, boolean.

Related issue

Closes #1116
References #851

⚠️ Should be merged only after backend is ready to support custom events.

@abhaysood abhaysood added feature new features android android related labels Aug 28, 2024
@abhaysood abhaysood self-assigned this Aug 28, 2024
@abhaysood abhaysood marked this pull request as draft August 28, 2024 09:06
Copy link

vercel bot commented Aug 28, 2024

The latest updates on your projects. Learn more about Vercel for Git ↗︎

Name Status Preview Comments Updated (UTC)
measure-dashboard ✅ Ready (Inspect) Visit Preview 💬 Add feedback Nov 27, 2024 8:48am

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
android android related feature new features
Projects
Status: In Progress
Development

Successfully merging this pull request may close these issues.

Implement custom events
1 participant