Add eslint-config-mdrobny

.eslintrc.js

@@ -0,0 +1,3 @@
+module.exports = {
+    extends: 'eslint-config-mdrobny'
+}

lib/spy.js

@@ -1,3 +1,4 @@
+/* eslint-disable prefer-rest-params */
 /**
  * Calls original method but intercepts how many times it was called and with what arguments
  * {Object} [object]
@@ -8,7 +9,7 @@ function spy(object, method) {
         throw new Error('Object passed but method is missing');
     }
     if (object && method && !object[method]) {
-        throw new Error(`Object does not have method "${method}"`)
+        throw new Error(`Object does not have method "${method}"`);
     }
 
     const isObjectVariant = object && method && object[method];
@@ -18,15 +19,16 @@ function spy(object, method) {
         cachedMethod = object[method].bind(object);
     }
 
-    const spyFn = function() {
+    function spyFn() {
         const args = Array.prototype.slice.call(arguments);
         spyFn.called++;
         spyFn.args.push(args);
 
         if (isObjectVariant) {
             return cachedMethod.apply(object, args);
         }
-    };
+        return undefined;
+    }
 
     spyFn.reset = () => {
         spyFn.called = 0;

lib/stub.js

@@ -1,3 +1,4 @@
+/* eslint-disable prefer-rest-params, no-param-reassign */
 /**
  * Prevents calling original method and instead calls mock function if defined
  * intercepts how many times it was called and with what arguments
@@ -11,7 +12,7 @@ function stub(object, method, fn) {
     }
 
     if (object && method && !object[method]) {
-        throw new Error(`Object does not have method "${method}"`)
+        throw new Error(`Object does not have method "${method}"`);
     }
 
     const isObjectVariant = object && method && object[method];
@@ -21,17 +22,17 @@ function stub(object, method, fn) {
         cachedMethod = object[method].bind(object);
     }
 
-    const stubFn = function() {
+    function stubFn() {
         const args = Array.prototype.slice.call(arguments);
 
         stubFn.called++;
         stubFn.args.push(args);
 
         if (fn) {
-            return fn.apply(undefined, args);
+            return fn(...args);
         }
         return undefined;
-    };
+    }
 
     stubFn.reset = () => {
         stubFn.called = 0;

package.json

@@ -4,7 +4,8 @@
   "description": "Spy and stub utils for testing",
   "main": "index.js",
   "scripts": {
-    "test": "mocha test/*.test.js"
+    "lint": "eslint . --ignore-path .gitignore",
+    "test": "mocha test/*.test.js && npm run lint"
   },
   "engines": {
     "node": ">=4"
@@ -19,13 +20,15 @@
     "test",
     "testing"
   ],
-  "author": "mdrobny",
+  "author": "Michal Drobniak <[email protected]>",
   "license": "ISC",
   "bugs": {
     "url": "https://github.com/mdrobny/spy-stub/issues"
   },
   "homepage": "https://github.com/mdrobny/spy-stub#readme",
   "devDependencies": {
+    "eslint": "^3.14.1",
+    "eslint-config-mdrobny": "^1.0.0",
     "mocha": "^3.2.0"
   }
 }

test/spy.test.js

@@ -1,6 +1,7 @@
 const assert = require('assert');
 
 const mocha = require('mocha');
+
 const describe = mocha.describe;
 const it = mocha.it;
 

test/stub.test.js

@@ -1,6 +1,7 @@
 const assert = require('assert');
 
 const mocha = require('mocha');
+
 const describe = mocha.describe;
 const it = mocha.it;
 
@@ -121,7 +122,7 @@ describe('Stub', () => {
             };
             const method = 'method';
 
-            const mockFn = () => `mock`;
+            const mockFn = () => 'mock';
             const methodStub = stub(object, method, mockFn);
 
             const result = object.method();