Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

OM_DVGEOCOMP tests and forward mode derivatives #250

Merged
merged 58 commits into from
Dec 9, 2024
Merged
Changes from 3 commits
Commits
Show all changes
58 commits
Select commit Hold shift + click to select a range
754b588
parameterized mphys test format
hajdik Jul 2, 2024
789ab36
Use assert_check_totals
eytanadler Jul 3, 2024
0c5e392
DVCon tests for most common functions on a box geometry
eytanadler Jul 3, 2024
8946952
Removed unused assert_check_partials import
eytanadler Jul 3, 2024
9d1a470
Error if any derivative mode other than rev is selected
eytanadler Jul 7, 2024
01dca80
Fixed if check
eytanadler Jul 7, 2024
1026304
Sorry black
eytanadler Jul 7, 2024
b5c7035
start esp test
hajdik Jul 15, 2024
8cf2e26
Fix missing var check in totalSensitivityProd
eytanadler Jul 19, 2024
1dd8558
Made projected area derivative inequality check consistent with primal
eytanadler Jul 19, 2024
65d20c6
Add fwd mode derivatives to OM_DVGEOCOMP
eytanadler Jul 19, 2024
35e9b70
Check both forward and reverse mode derivatives
eytanadler Jul 19, 2024
6f2e02e
Removed explicit mode setting when not doing derivative test
eytanadler Jul 19, 2024
9bb6d32
Merge branch 'mphys-tests' of github.com:mdolab/pygeo into mphys-tests
hajdik Aug 12, 2024
c6af0bd
Reverse mode DVGeo derivatives should actually use reverse mode
eytanadler Aug 12, 2024
4c69161
Merge branch 'mphys-tests' of github.com:mdolab/pygeo into mphys-tests
hajdik Aug 12, 2024
58debb9
Modify DVCon test FD step size
eytanadler Aug 12, 2024
e518685
Merge branch 'mphys-tests' of github.com:mdolab/pygeo into mphys-tests
eytanadler Aug 12, 2024
f5ae8ea
hide esp
hajdik Aug 12, 2024
709a1e1
Cleaned up cross_b and dot_b
eytanadler Aug 12, 2024
52311b1
Merge branch 'mphys-tests' of github.com:mdolab/pygeo into mphys-tests
eytanadler Aug 12, 2024
863f065
add shape func dv test (doesn't work :/
hajdik Aug 13, 2024
bb0705f
pull generic part of shape func dv out to use it in mphys too
hajdik Aug 13, 2024
c2422f5
Merge branch 'mphys-tests' of github.com:mdolab/pygeo into mphys-tests
hajdik Aug 13, 2024
57cad59
Merged mdolab/pygeo main in
eytanadler Oct 15, 2024
4ca06d5
Merged mdolab/pygeo main in
eytanadler Oct 15, 2024
2c5288a
Merge branch 'mphys-tests' of github.com:mdolab/pygeo into mphys-tests
eytanadler Oct 15, 2024
230880b
Reenable fwd mode mphys tests
eytanadler Oct 15, 2024
7032729
Fix derivative problems with projected area constraint
eytanadler Oct 15, 2024
cff644a
formatting
hajdik Oct 16, 2024
0521abf
ESP test
hajdik Oct 16, 2024
dbf00ae
kwargs -> real args
hajdik Oct 16, 2024
48bdc15
fix
hajdik Oct 16, 2024
16383ad
Merge branch 'mphys-tests' of github.com:mdolab/pygeo into mphys-tests
hajdik Oct 16, 2024
53102a7
add parameter from DVGeoESP
hajdik Oct 17, 2024
5a6c42a
fix ESP test
hajdik Oct 17, 2024
d0bf709
Merge branch 'mphys-tests' into mphys_deriv
eytanadler Oct 17, 2024
f3b7cee
Adjust tol
eytanadler Oct 17, 2024
86c2926
Fix formatting
eytanadler Oct 17, 2024
5dc7071
Please flake
eytanadler Oct 17, 2024
7603a7b
Fix bad python
eytanadler Oct 17, 2024
7f0cf59
Ignore unused import
eytanadler Oct 17, 2024
b61fafd
Flake 8 fixes
eytanadler Oct 17, 2024
fc39ee9
Remove previous uneeded ignore
eytanadler Oct 17, 2024
1b4b27a
isort
hajdik Oct 17, 2024
7fadb24
first try
hajdik Oct 17, 2024
6aa0781
first try for sure
hajdik Oct 17, 2024
0668152
sure
hajdik Oct 17, 2024
e2d742f
?
hajdik Oct 17, 2024
a321803
This one will work
eytanadler Oct 17, 2024
fb15b8b
Remove directional kwarg that was unused and broke old OM versions
eytanadler Oct 25, 2024
4871a3d
take out parallel case - test not set up for it
hajdik Oct 25, 2024
c790303
Merge branch 'mphys_deriv' of github.com:eytanadler/pygeo into mphys_…
hajdik Oct 25, 2024
e735915
You're not gonna believe this one cool trick
eytanadler Oct 25, 2024
6eb7b53
Merge branch 'mphys_deriv' of github.com:eytanadler/pygeo into mphys_…
eytanadler Oct 25, 2024
d441801
Isort is the devil
eytanadler Oct 25, 2024
4712171
Address Andrew's comments
eytanadler Nov 12, 2024
ec99fe4
Jostle the interpretation
eytanadler Nov 26, 2024
File filter

Filter by extension

Filter by extension

Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
2 changes: 2 additions & 0 deletions pygeo/mphys/mphys_dvgeo.py
Original file line number Diff line number Diff line change
Expand Up @@ -947,3 +947,5 @@
# in multiple objective seeds with totalSensitivity. we can remove the [0]
# once we move back to totalSensitivityTransProd
d_inputs[k] += xdotg[k][0]
elif mode != "rev":
raise RuntimeError(f'OM_DVGEOCOMP supports only "rev" derivative mode, but "{mode}" was selected')

Check warning on line 951 in pygeo/mphys/mphys_dvgeo.py

View check run for this annotation

Codecov / codecov/patch

pygeo/mphys/mphys_dvgeo.py#L950-L951

Added lines #L950 - L951 were not covered by tests