Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix .head causing JsonSupport sink to terminate #93

Merged
merged 1 commit into from
Sep 12, 2024

Conversation

mdedetrich
Copy link
Owner

@mdedetrich mdedetrich commented Sep 12, 2024

Resolves: #15

This seems to have been an honest mistake when copying the original code from the project at https://github.com/knutwalker/akka-stream-json/blob/master/http-json/src/main/scala/de/knutwalker/akka/http/JsonSupport.scala

I must have done some "optimization" or "improvement" while causing a regression that slipped through current test coverage.

@mdedetrich mdedetrich force-pushed the fix-head-causing-sink-to-terminate branch from 5d76584 to 1d151de Compare September 12, 2024 09:27
@coveralls
Copy link

coveralls commented Sep 12, 2024

Pull Request Test Coverage Report for Build 10828056638

Details

  • 20 of 27 (74.07%) changed or added relevant lines in 1 file are covered.
  • 4 unchanged lines in 1 file lost coverage.
  • Overall coverage decreased (-5.0%) to 88.976%

Changes Missing Coverage Covered Lines Changed/Added Lines %
http-json/src/main/scala/org/mdedetrich/pekko/http/JsonSupport.scala 20 27 74.07%
Files with Coverage Reduction New Missed Lines %
stream-json/src/main/scala/org/mdedetrich/pekko/json/stream/JsonStreamParser.scala 4 82.98%
Totals Coverage Status
Change from base Build 10810334661: -5.0%
Covered Lines: 113
Relevant Lines: 127

💛 - Coveralls

@mdedetrich mdedetrich merged commit 3c19fcf into main Sep 12, 2024
36 checks passed
@mdedetrich mdedetrich deleted the fix-head-causing-sink-to-terminate branch September 12, 2024 09:41
@jrudolph
Copy link

I must have done some "optimization" or "improvement" while causing a regression that slipped through current test coverage.

Ah, interesting, that also explains the difference of behavior with Pekko :) Thanks for the quick fix.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Problem with unmarshaling
3 participants