Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

New option for resetting timers #149

Open
wants to merge 1 commit into
base: master
Choose a base branch
from
Open
Changes from all commits
Commits
File filter

Filter by extension

Filter by extension

Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
40 changes: 27 additions & 13 deletions bootstrap-hover-dropdown.js
Original file line number Diff line number Diff line change
Expand Up @@ -9,7 +9,7 @@
* License: MIT
* Homepage: http://cameronspear.com/blog/bootstrap-dropdown-on-hover-plugin/
*/
;(function ($, window, undefined) {
; (function ($, window, undefined) {
// outside the scope of the jQuery plugin to
// keep track of all dropdowns
var $allDropdowns = $();
Expand All @@ -19,7 +19,7 @@
$.fn.dropdownHover = function (options) {
// don't do anything if touch is supported
// (plugin causes some issues on mobile)
if('ontouchstart' in document) return this; // don't want to affect chaining
if ('ontouchstart' in document) return this; // don't want to affect chaining

// the element we really care about
// is the dropdown-toggle's parent
Expand All @@ -31,23 +31,25 @@
defaults = {
delay: 500,
hoverDelay: 0,
instantlyCloseOthers: true
instantlyCloseOthers: true,
extraHover: ""
},
data = {
delay: $(this).data('delay'),
hoverDelay: $(this).data('hover-delay'),
instantlyCloseOthers: $(this).data('close-others')
instantlyCloseOthers: $(this).data('close-others'),
extraHover: $(this).data('extra-hover')
},
showEvent = 'show.bs.dropdown',
hideEvent = 'hide.bs.dropdown',
showEvent = 'show.bs.dropdown',
hideEvent = 'hide.bs.dropdown',
// shownEvent = 'shown.bs.dropdown',
// hiddenEvent = 'hidden.bs.dropdown',
settings = $.extend(true, {}, defaults, options, data),
timeout, timeoutHover;

$parent.hover(function (event) {
// so a neighbor can't open the dropdown
if(!$parent.hasClass('open') && !$this.is(event.target)) {
if (!$parent.hasClass('open') && !$this.is(event.target)) {
// stop this event, stop executing any code
// in this callback but continue to propagate
return true;
Expand All @@ -68,7 +70,7 @@
$this.hover(function (event) {
// this helps prevent a double event from firing.
// see https://github.com/CWSpear/bootstrap-hover-dropdown/issues/55
if(!$parent.hasClass('open') && !$parent.is(event.target)) {
if (!$parent.hasClass('open') && !$parent.is(event.target)) {
// stop this event, stop executing any code
// in this callback but continue to propagate
return true;
Expand All @@ -77,8 +79,20 @@
openDropdown(event);
});

// reset timer on hovering extra hover elements
if (settings.extraHover.length > 0) {
$(settings.extraHover).hover(function () {
window.clearTimeout(timeout);
}, function () {
var $submenu = $this.children('.dropdown-menu');
timeout = window.setTimeout(function () {
$submenu.hide();
}, settings.delay);
});
}

// handle submenus
$parent.find('.dropdown-submenu').each(function (){
$parent.find('.dropdown-submenu').each(function () {
var $this = $(this);
var subTimeout;
$this.hover(function () {
Expand All @@ -95,7 +109,7 @@
});

function openDropdown(event) {
if($this.parents(".navbar").find(".navbar-toggle").is(":visible")) {
if ($this.parents(".navbar").find(".navbar-toggle").is(":visible")) {
// If we're inside a navbar, don't do anything when the
// navbar is collapsed, as it makes the navbar pretty unusable.
return;
Expand All @@ -105,14 +119,14 @@
window.clearTimeout(timeout);
// restart hover timer
window.clearTimeout(timeoutHover);

// delay for hover event.
timeoutHover = window.setTimeout(function () {
$allDropdowns.find(':focus').blur();

if(settings.instantlyCloseOthers === true)
if (settings.instantlyCloseOthers === true)
$allDropdowns.removeClass('open');

// clear timer for hover event
window.clearTimeout(timeoutHover);
$this.attr('aria-expanded', 'true');
Expand Down