Skip to content

Commit

Permalink
skip notebook check for python 3.7 and 3.8
Browse files Browse the repository at this point in the history
  • Loading branch information
tkittel committed Aug 30, 2024
1 parent 331801c commit 927ddad
Showing 1 changed file with 3 additions and 1 deletion.
4 changes: 3 additions & 1 deletion .github/workflows/basictest.yml
Original file line number Diff line number Diff line change
Expand Up @@ -28,7 +28,6 @@ jobs:
include:
#Note: Python 3.13 works (Aug 2024) because of the
#"allow-prereleases: true" below.
- { os: ubuntu-20.04, CC: gcc, CXX: g++, python: '3.7' }
- { os: ubuntu-20.04, CC: gcc-10, CXX: g++-10, python: '3.8' }
- { os: ubuntu-22.04, CC: gcc, CXX: g++, python: '3.9' }
- { os: ubuntu-latest, CC: gcc, CXX: g++, python: '3.10' }
Expand Down Expand Up @@ -173,17 +172,20 @@ jobs:
. ${{github.workspace}}/install/ncrystal_unsetup.sh
- name: Checkout ncrystal-notebooks
if: matrix.python != '3.7' && matrix.python != '3.8'
uses: actions/checkout@v4
with:
repository: mctools/ncrystal-notebooks
path: src_notebooks

- name: Extra pip install for notebooks
if: matrix.python != '3.7' && matrix.python != '3.8'
run: |
set -eu
python3 -m pip install numpy matplotlib spglib ase gemmi jupyterlab ipympl
- name: Test notebooks
if: matrix.python != '3.7' && matrix.python != '3.8'
run: |
set -eu
eval $(${{github.workspace}}/install/bin/ncrystal-config --setup)
Expand Down

0 comments on commit 927ddad

Please sign in to comment.