feat: add dev ui #1036
Open
feat: add dev ui #1036
+870
−67
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Format Checker ReportAll files are correctly formatted |
Dudeplayz
force-pushed
the
issues/33-add-dev-ui
branch
from
44c7f5e to
e25cc5a
Compare
mcollovati
requested changes
Nov 3, 2024
There was a problem hiding this comment.
Overall, looks excellent!
However, I noticed that methods defined in superclasses annotated with @EndpointExposed are not listed in the UI.
I guess this is because ClassInfo.methods() collects only method declared in the class and do not traverse the hierarchy
...loyment/src/main/java/com/github/mcollovati/quarkus/hilla/deployment/devui/EndpointInfo.java
Outdated
Show resolved
Hide resolved
...loyment/src/main/java/com/github/mcollovati/quarkus/hilla/deployment/devui/EndpointInfo.java
Outdated
Show resolved
Hide resolved
mcollovati
reviewed
Nov 3, 2024
commons/deployment/src/main/resources/dev-ui/qwc-quarkus-hilla-endpoints.js
Outdated
Show resolved
Hide resolved
Dudeplayz
force-pushed
the
issues/33-add-dev-ui
branch
from
e25cc5a to
1bcf13c
Compare
Dudeplayz
force-pushed
the
issues/33-add-dev-ui
branch
from
5b3e8d3 to
dd060df
Compare
* Run build steps only for associated security policy
Dudeplayz
force-pushed
the
issues/33-add-dev-ui
branch
from
d2ae17b to
57a5949
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Implements #33