Demo PR for issue #772 - add API to get temperature value of SX 127x chip #774
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Demo PR for issue mcci-catena#772 - add API to get temperature value of SX 127x chip
|
I polished the PR, following your hints. But not ready yet. |
|
@cyberman54 is this still not ready? If so, I'll move to next release. |
|
In my tests it works. But it's probably a breaking change, because it touches the LMIC struct? |
I don't think it's a breaking change per se; adding a new field to the radio is no problem. But it adds more code, which might be a problem. I think I'll leave merging this for later, after I or others have a chance to experiment with it some. |
fix configPower for sx1272
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Seems to work, but not sure if or when it is safe to call new api
radio_GetRawTemp().