Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

✨ init bs.interaction #234

Merged
merged 18 commits into from
Nov 23, 2024
Merged

✨ init bs.interaction #234

merged 18 commits into from
Nov 23, 2024

Conversation

theogiraudet
Copy link
Contributor

@theogiraudet theogiraudet commented Jul 15, 2024

Tasks to do before merging

  • I accept to publish my contribution under MPL v2 License
  • My pull request is linked to an existing issue
  • I have added my contribution to the changelog
  • If my pull request is a new or modify an existing feature:
    • I have documented my contribution (/docs)
    • I have added or updated the header of the features' root function I contribute
    • I have tested my contribution

@theogiraudet
Copy link
Contributor Author

Close #193

@theogiraudet theogiraudet linked an issue Jul 15, 2024 that may be closed by this pull request
8 tasks
@theogiraudet
Copy link
Contributor Author

@aksiome The code is not really up to date, but you can check the beginning of the documentation about the interaction API, if you have some feedback.
As you will see, there currently are three APIs in this module.
To discuss.

@aksiome

This comment was marked as resolved.

@theogiraudet

This comment was marked as resolved.

@aksiome

This comment was marked as resolved.

@theogiraudet

This comment was marked as resolved.

@aksiome

This comment was marked as resolved.

@aksiome aksiome marked this pull request as ready for review November 8, 2024 14:34
Copy link
Contributor Author

@theogiraudet theogiraudet left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Two things about the documentation:

  • I think the term "listener" is not useful anymore, we can replace it by "interaction entity".
  • Should we document the default callback?
    Finally, the module is not documented in the changelog.

docs/CHANGELOG.md Outdated Show resolved Hide resolved
docs/modules/interaction.md Outdated Show resolved Hide resolved
@theogiraudet theogiraudet changed the title ✨ init bs.gui ✨ init bs.interaction Nov 23, 2024
@theogiraudet theogiraudet merged commit 105bfa4 into mcbookshelf:master Nov 23, 2024
3 checks passed
@theogiraudet theogiraudet deleted the gui branch November 23, 2024 16:42
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants