Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Added HeartbeatMissed error and counter of missed heartbeats #53

Open
wants to merge 1 commit into
base: master
Choose a base branch
from

Conversation

KonstantinZvyagin
Copy link

Some times it's good to see that heartbeat is lost. That means we got a cable cut or some rare situation.

@droidsyer
Copy link
Contributor

Good idea to notify missing heartbeat!
Actually if the ethernet cable is unplugged the socket is not able to detect disconnection.

Why this pull request has not been merged?

@droidsyer
Copy link
Contributor

@mbroadst I have just analized the heartbeat mechanism on RabbitMQ. I propose a simplier solution, but it doesn't work properly:
Add a signal when heartbeat from server arrives. Handling heartbeat controlling within application client of qamqp.
However I verify that this works only for a single client connected to the server. When I try to connect the second client, the server send heartbeat only at second client. So the first one disconnects because of heartbeat missing.

Perhaps this is the reason why you didn't implement this mechanism.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants