step_ca_provisioner: make idempotent, remove 'updated' state #355
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
maxhoesel
added
pr-major
maxhoesel
force-pushed
the
provisioner_state
branch
4 times, most recently
from
cc03f6d to
f4cefda
Compare
This commit allows `step_ca_provisioner` to determine whether a given provisioner has been changed, be that through creation or an update. We do this by comparing the provisioner config before and after running the `create/update` command. This has the side-effect of making this module check-mode-incompatible, since there is no way to tell whether a provisioner has changed without actually applying it. This commit also fixes some behavior around the --create parameter to ensure idempotency, as well as some other minor details.
maxhoesel
force-pushed
the
provisioner_state
branch
from
f4cefda to
21f3827
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This commit allows
step_ca_provisionerto determine whethera given provisioner has been changed, be that through creation
or an update.
We do this by comparing the provisioner config before and after
running the
create/updatecommand.This has the side-effect of making this module check-mode-incompatible,
since there is no way to tell whether a provisioner has changed without
actually applying it.
This commit also fixes some behavior around the --create parameter
to ensure idempotency,
as well as some other minor details.