[step_ca] Rework existing cert variables to be more readable and clear #308
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
maxhoesel
added
the
pr-major
maxhoesel
commented
Aug 1, 2023
| - If the file is present on the controller instead of the target node, set `step_ca_existing_<root/key>_is_local`, to `true`. | ||
| - Default: not set (will generate a new certificate) | ||
|
|
||
| ##### `step_ca_existing_<root/key>_is_local` |
There was a problem hiding this comment.
Instead of is_local, perhaps a _mode parameter would be better, with the default behavior of none and choices for local and remote. This would allow for easy extendability in the future
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This change modifies the variables for initializing the CA with an existing key and certificate and makes them more readable.
This also removes the old, confusing behavior that was introduced when the role gained the ability to use both remote and local certificate files as a source. To simplify things, the names of the parameters have been updated and made more explicit.
Tests have also been added to ensure that all three paths (existing local, remote and no previous certificate) all work as expected.
Since this PR changes the names of variables without a fallback, this is a breaking change.
As this only affects initial CA setup, any impact on existing users should be minimal.
Updating the parameter names and values is all that is required for migrating to this new system