Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Update electron to 27 #458

Merged
merged 4 commits into from
Nov 28, 2023
Merged

Update electron to 27 #458

merged 4 commits into from
Nov 28, 2023

Conversation

MvRemmerden
Copy link
Contributor

No description provided.

@MvRemmerden
Copy link
Contributor Author

@amaury1729 One more update to electron 🙂

@MvRemmerden
Copy link
Contributor Author

@amaury1729 Any chance we can get this merged? 🙂

@amaury1093
Copy link
Collaborator

Thanks for the pr! could you update the yarn.lock files? Just run yarn install in the 2 folders. Also, could you update the README file?

@MvRemmerden
Copy link
Contributor Author

@amaury1729 Done, back to you :)

amaury1093
amaury1093 approved these changes Nov 28, 2023
View reviewed changes
Copy link
Collaborator

@amaury1093 amaury1093 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks!

@amaury1093 amaury1093 merged commit f3dbac6 into max-mapper:master Nov 28, 2023
1 check failed
@MvRemmerden MvRemmerden deleted the patch-1 branch November 28, 2023 18:27
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@amaury1093 amaury1093 amaury1093 approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@MvRemmerden @amaury1093