Android: Fix Serial Issues #12063
Merged
Android: Fix Serial Issues #12063
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
HTRamsey
force-pushed
the
dev-android-serial
branch
8 times, most recently
from
af62984
to
6ccecb8
Compare
HTRamsey
force-pushed
the
dev-android-serial
branch
from
6ccecb8
to
744e1f2
Compare
| @@ -285,7 +285,7 @@ bool JoystickAndroid::init() { | |||
| return true; | |||
| } | |||
|
|
|||
| static const char kJniClassName[] {"org/mavlink/qgroundcontrol/QGCActivity"}; | |||
| static const char kJniClassName[] {"org/mavlink/qgroundcontrol/QGCUsbSerialManager"}; | |||
There was a problem hiding this comment.
Is this correct. Seems strange?
There was a problem hiding this comment.
Yeah, it's because all the serial methods were moved to a separate class "QGCUsbSerialManager" to organize the code a bit.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Closes #12031
Hopefully fixes freezing after several hours by increasing buffer and adding memory checks
Moves serial code to another java class for better organization
Better debugging output and result verification
Moving serial link to a separate thread should resolve any remaining issues