UTMSPManager: Convert to Singleton #12019
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
HTRamsey
force-pushed
the
dev-tools-airlink-utmsp
branch
2 times, most recently
from
3228bf9
to
74d7ddc
Compare
HTRamsey
force-pushed
the
dev-tools-airlink-utmsp
branch
from
74d7ddc
to
f6ff5e2
Compare
HTRamsey
force-pushed
the
dev-tools-airlink-utmsp
branch
from
f6ff5e2
to
e01b051
Compare
|
@HTRamsey I'd ask the UTMSP folks who created this to review. I'm not familiar with this code. |
|
There aren't really any changes to the code except for a couple small memory leak fixes but that's fair. Should I split out the airlink stuff to a different PR? |
HTRamsey
changed the title
HTRamsey
force-pushed
the
dev-tools-airlink-utmsp
branch
from
e01b051
to
2814c75
Compare
HTRamsey
force-pushed
the
dev-tools-airlink-utmsp
branch
2 times, most recently
from
ad6db81
to
d40f658
Compare
|
@royzah since you seem to use this code, could you check/test this? Trying to remove toolbox and use singletons instead |
HTRamsey
force-pushed
the
dev-tools-airlink-utmsp
branch
from
d40f658
to
30690a0
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Convert from tools to singletons