Telemetry Bar: Fix turning on edit for mobile #10761
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Davidsastresas
approved these changes
Aug 8, 2023
|
Thanks! I wasn't aware this was broken in Android. I just checked and indeed the only way to edit the panel is clicking, and then sliding up to the lock icon, otherwise it isn't possible. It looks good to me, I think it is good to merge. Thanks! |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
A change was made a while back to the telemetry values bar to use hover instead of click to show the edit tools to unlock it. This works fine if you have a mouse. But on mobile it doesn't really work at all since there is no concept of "hover". I changed the code such that mobile goes back to the way it was before which is a click will enter edit mode. Non-mobile mouse stays with the same hover behavior.